Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=727635 --- Comment #1 from Omair Majid <omajid@xxxxxxxxxx> 2011-08-02 14:42:34 EDT --- === REQUIRED ITEMS === [!] Rpmlint output: SPECS/java-1.7.0-openjdk.spec:91: W: macro-in-comment %{jit_arches} SPECS/java-1.7.0-openjdk.spec:121: E: hardcoded-library-path in %{_prefix}/lib SPECS/java-1.7.0-openjdk.spec:163: W: macro-in-comment %define SPECS/java-1.7.0-openjdk.spec:163: W: macro-in-comment %{sdkdir} SPECS/java-1.7.0-openjdk.spec:189: W: macro-in-comment %{icedtea_jdk7_snapshot} SPECS/java-1.7.0-openjdk.spec:190: W: macro-in-comment %{corba_snapshot} SPECS/java-1.7.0-openjdk.spec:191: W: macro-in-comment %{hotspot_snapshot} SPECS/java-1.7.0-openjdk.spec:192: W: macro-in-comment %{jaxp_snapshot} SPECS/java-1.7.0-openjdk.spec:193: W: macro-in-comment %{jaxws_snapshot} SPECS/java-1.7.0-openjdk.spec:194: W: macro-in-comment %{jdk_snapshot} SPECS/java-1.7.0-openjdk.spec:195: W: macro-in-comment %{langtools_snapshot} SPECS/java-1.7.0-openjdk.spec:785: E: hardcoded-library-path in /usr/lib/jvm/java-gcj/* SPECS/java-1.7.0-openjdk.spec:818: E: hardcoded-library-path in /usr/lib/jvm/java-gcj/jre/lib/rt.jar SPECS/java-1.7.0-openjdk.spec:908: W: configure-without-libdir-spec SPECS/java-1.7.0-openjdk.spec:932: W: configure-without-libdir-spec SPECS/java-1.7.0-openjdk.spec:1317: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1320: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1321: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1322: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1323: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1324: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1351: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1351: W: macro-in-comment %{buildoutputdir} SPECS/java-1.7.0-openjdk.spec:1354: W: macro-in-comment %doc SPECS/java-1.7.0-openjdk.spec:1468: W: macro-in-%changelog %{_jvmdir} SPECS/java-1.7.0-openjdk.spec:1468: W: macro-in-%changelog %{jredir} SPECS/java-1.7.0-openjdk.spec:1470: W: macro-in-%changelog %{_jvmdir} SPECS/java-1.7.0-openjdk.spec:1470: W: macro-in-%changelog %{sdkdir} SPECS/java-1.7.0-openjdk.spec:163: W: mixed-use-of-spaces-and-tabs (spaces: line 32, tab: line 163) SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch0: java-1.7.0-openjdk-optflags.patch SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch1: java-1.7.0-openjdk-java-access-bridge-tck.patch SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch2: java-1.7.0-openjdk-java-access-bridge-idlj.patch SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch3: java-1.7.0-openjdk-java-access-bridge-security.patch SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch4: java-1.7.0-openjdk-accessible-toolkit.patch SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch5: java-1.7.0-openjdk-debugdocs.patch SPECS/java-1.7.0-openjdk.spec: W: patch-not-applied Patch6: %{name}-debuginfo.patch SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source14: pulseaudio.tar.gz SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source12: desktop-files.tar.gz SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source11: systemtap-tapset.tar.gz SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source10: class-rewriter.tar.gz SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source9: generated-files.tar.gz SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source6: https://java.net/downloads/jax-ws/JDK7/jdk7-jaf-2010_08_19.zip HTTP Error 404: Not Found SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source3: mauve-2008-10-22.tar.gz SPECS/java-1.7.0-openjdk.spec: W: invalid-url Source0: icedtea-jdk7.tar.gz java-1.7.0-openjdk.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment java-1.7.0-openjdk.src: W: invalid-license ASL 1.1, ASL 2.0, GPL+, GPLv2, GPLv2 with exceptions, LGPL+, LGPLv2, MPLv1.0, MPLv1.1, Public Domain, W3C java-1.7.0-openjdk.src: W: strange-permission javac-wrapper 0775L java-1.7.0-openjdk.src:91: W: macro-in-comment %{jit_arches} java-1.7.0-openjdk.src:121: E: hardcoded-library-path in %{_prefix}/lib java-1.7.0-openjdk.src:163: W: macro-in-comment %define java-1.7.0-openjdk.src:163: W: macro-in-comment %{sdkdir} java-1.7.0-openjdk.src:189: W: macro-in-comment %{icedtea_jdk7_snapshot} java-1.7.0-openjdk.src:190: W: macro-in-comment %{corba_snapshot} java-1.7.0-openjdk.src:191: W: macro-in-comment %{hotspot_snapshot} java-1.7.0-openjdk.src:192: W: macro-in-comment %{jaxp_snapshot} java-1.7.0-openjdk.src:193: W: macro-in-comment %{jaxws_snapshot} java-1.7.0-openjdk.src:194: W: macro-in-comment %{jdk_snapshot} java-1.7.0-openjdk.src:195: W: macro-in-comment %{langtools_snapshot} java-1.7.0-openjdk.src:785: E: hardcoded-library-path in /usr/lib/jvm/java-gcj/* java-1.7.0-openjdk.src:818: E: hardcoded-library-path in /usr/lib/jvm/java-gcj/jre/lib/rt.jar java-1.7.0-openjdk.src:908: W: configure-without-libdir-spec java-1.7.0-openjdk.src:932: W: configure-without-libdir-spec java-1.7.0-openjdk.src:1317: W: macro-in-comment %doc java-1.7.0-openjdk.src:1320: W: macro-in-comment %doc java-1.7.0-openjdk.src:1321: W: macro-in-comment %doc java-1.7.0-openjdk.src:1322: W: macro-in-comment %doc java-1.7.0-openjdk.src:1323: W: macro-in-comment %doc java-1.7.0-openjdk.src:1324: W: macro-in-comment %doc java-1.7.0-openjdk.src:1351: W: macro-in-comment %doc java-1.7.0-openjdk.src:1351: W: macro-in-comment %{buildoutputdir} java-1.7.0-openjdk.src:1354: W: macro-in-comment %doc java-1.7.0-openjdk.src:1468: W: macro-in-%changelog %{_jvmdir} java-1.7.0-openjdk.src:1468: W: macro-in-%changelog %{jredir} java-1.7.0-openjdk.src:1470: W: macro-in-%changelog %{_jvmdir} java-1.7.0-openjdk.src:1470: W: macro-in-%changelog %{sdkdir} java-1.7.0-openjdk.src:163: W: mixed-use-of-spaces-and-tabs (spaces: line 32, tab: line 163) java-1.7.0-openjdk.src: W: patch-not-applied Patch0: java-1.7.0-openjdk-optflags.patch java-1.7.0-openjdk.src: W: patch-not-applied Patch1: java-1.7.0-openjdk-java-access-bridge-tck.patch java-1.7.0-openjdk.src: W: patch-not-applied Patch2: java-1.7.0-openjdk-java-access-bridge-idlj.patch java-1.7.0-openjdk.src: W: patch-not-applied Patch3: java-1.7.0-openjdk-java-access-bridge-security.patch java-1.7.0-openjdk.src: W: patch-not-applied Patch4: java-1.7.0-openjdk-accessible-toolkit.patch java-1.7.0-openjdk.src: W: patch-not-applied Patch5: java-1.7.0-openjdk-debugdocs.patch java-1.7.0-openjdk.src: W: patch-not-applied Patch6: %{name}-debuginfo.patch java-1.7.0-openjdk.src: W: invalid-url Source14: pulseaudio.tar.gz java-1.7.0-openjdk.src: W: invalid-url Source12: desktop-files.tar.gz java-1.7.0-openjdk.src: W: invalid-url Source11: systemtap-tapset.tar.gz java-1.7.0-openjdk.src: W: invalid-url Source10: class-rewriter.tar.gz java-1.7.0-openjdk.src: W: invalid-url Source9: generated-files.tar.gz java-1.7.0-openjdk.src: W: invalid-url Source6: https://java.net/downloads/jax-ws/JDK7/jdk7-jaf-2010_08_19.zip HTTP Error 404: Not Found java-1.7.0-openjdk.src: W: invalid-url Source3: mauve-2008-10-22.tar.gz java-1.7.0-openjdk.src: W: invalid-url Source0: icedtea-jdk7.tar.gz 1 packages and 1 specfiles checked; 6 errors, 85 warnings. There are many false positives, but I am quite concerned about a few of these including invalid-url and patch not applied look rather serious. [!] Buildroot definition is not present Defining build root is depricated; it should not be defined. [!] All independent sub-packages have license of their own javadoc subpackage does not include the LICENSE file [!] Sources used to build the package matches the upstream source, as provided in the spec URL. I cant find the source for generated-files.tar.gz, class-rewriter.tar.gz, systemtap-tapset.tar.gz and pulseaudio.tar.gz - I can guess it's from icedtea6 or 7. [!] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [!] Javadoc subpackages have Require: jpackage-utils [!] Package uses %global not %define Please see http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define === Other suggestions === 1. Avoid having BuildRequires on exact NVR unless necessary (freetype-devel, pulseaudio-libs-devel pulseaudio,pkgconfig) 2. Package has BuildArch: noarch (if possible) The javadoc package should be noarch 3. The forest at icedtea.classpath.org/hg/icedtea7-forest is more up to date than hg.openjdk.java.net/icedtea/jdk7 4. execstack can be removed (fixed upstream: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/dddc5753c53a) 5. Priority should be 17000 (instead of 16000) 6. License field contents should use 'and' or 'or' (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios) 7. genurl macro defined by not used. 8. A comment says "update for jnlp handling", but this package provides no jnlp support 9. Changelogs are for icedtea6. Are they even needed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review