Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=727199 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2011-08-02 07:26:55 EDT --- Successfully built for F-15, see koji logs: http://koji.fedoraproject.org/koji/taskinfo?taskID=3246300 However there is a room for the SPEC-file improvement. 1. Please, add a comments on how to reproduce / rebuild tarball you're using. For example, take a look at the following SPEC-file: http://pkgs.fedoraproject.org/gitweb/?p=flashrom.git;a=blob;f=flashrom.spec;hb=HEAD 2. Parts of the SPEC-file, related to doc-files, should be simplified. Instead of installing doc-files explicitly you may use rpmbuild's internal doc-file processing routines. E.g. instead of ------------------------------------- %define pkgdocdir %{_datadir}/doc/%{name}-%{version} ... mkdir -p $RPM_BUILD_ROOT%{pkgdocdir} install -m 0644 COPYING $RPM_BUILD_ROOT%{pkgdocdir} install -m 0644 README $RPM_BUILD_ROOT%{pkgdocdir} ... %dir %{pkgdocdir}/ %doc %{pkgdocdir}/COPYING %doc %{pkgdocdir}/README ------------------------------------- you should just write ------------------------------------- %files ... %doc COPYING README ------------------------------------- and rpmbuild will do the rest. Please, comment/address these issues and I'll continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review