[Bug 702987] Review Request: stdair - C++ Standard Airline IT Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702987

--- Comment #11 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> 2011-07-31 10:14:27 EDT ---
(In reply to comment #10)

Thanks for those additional review elements.

> - The latest package doesn't build because of missing BR: python-devel
>   http://koji.fedoraproject.org/koji/taskinfo?taskID=3240849
>   There are possibly some more dependencies missing. Try to build the package
>   with mock/koji to find all deps.

I have fixed that dependency issue (I added the requirement in CMake helpers,
but forgot to add it back to the RPM specification file). mock now begins to
build the package.

> - As far as I can see, you can drop Requires: cmake since
>   %{_datadir}/cmake/ is not used (unlike mentioned in the comment).

You are absolutely right. Indeed, there is no need to put anything in
%{_datadir}/cmake/ (reserved for non-CMake-aware packages), as stdair provides
%{_datadir}/stdair/CMake/stdair-config*.cmake helpers (cleaner way for third
party projects to use the stdair library).

> - Please prefer plain shell commands (rm, install, chmod, etc. ) over macros
>   http://fedoraproject.org/wiki/PackagingGuidelines#Macros

Ooops, I forgot that one... It has been fixed (and I will remember for other
packages: thanks!).

> - Move the find command and the following "mydocs lines" from the %check 
>   to the %install section.

Ooops, it was not intentional (kind of typo). It has been fixed.

(In reply to comment #4)
> 
> - Also, it's not necessary to wrap the BuildArch field with conditionals.
> Just use plain BuildArch field.

I have left the macro around BuildArch because, if I remember correctly, it led
to some issue with EPEL <= 5 (for which I intend to deliver stdair as well).
More specifically, rpm, on those distributions, is/was not able to
build/deliver multi-architecture packages.

========

I have now a more tricky issue with CMake and the (HTML/PDF) documentation
generation. When compiling with parallel flag until '-j4', everything is fine.
But above (e.g., '-j6'), there is a dependency issue with the Latex-related
target (PDF reference manual generation). I have to look more thoroughly and to
try a few target inter-dependency mechanisms...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]