Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726131 Nathan Owe <ndowens04@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ndowens04@xxxxxxxxx --- Comment #2 from Nathan Owe <ndowens04@xxxxxxxxx> 2011-07-30 22:53:08 EDT --- Sorry I can not review the SPEC but I will try and point out some things I see: in this line of sed: sed -e "s/dirname(dirname(__FILE__)).'\/user\/config.php'/'\%{_sysconfdir}\/%{name}\/config.php'/g" \ -e "s/config.php in \/user\//config.php in \%{_sysconfdir}\/%{name}\//g" \ -i ./includes/load-yourls.php you can use | instead of / so it will look cleaner and easier to read. License is wrong I couldn't find the exact version of the GPL the application is licensed so license field should be GPL+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review