Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726841 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx QAContact|extras-qa@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-07-29 20:41:09 EDT --- $ rpmlint python-mx-* python-mx.src: W: strange-permission egenix-mx-base-3.2.0.tar.gz 0444L python-mx.src: E: invalid-spec-name python-mx.src:20: W: unversioned-explicit-provides mx python-mx.src:21: W: unversioned-explicit-obsoletes mx python-mx.src:32: W: unversioned-explicit-provides mx-devel python-mx.src:33: W: unversioned-explicit-obsoletes mx-devel python-mx.src:82: W: macro-in-comment %{_bindir} python-mx.x86_64: W: self-obsoletion mx obsoletes mx python-mx.x86_64: W: self-obsoletion mx2 <= 3.2.0-2.fc15 obsoletes mx2 = 3.2.0-2.fc15 python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/Proxy/mxProxy/mxProxy.so mxProxy.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/Queue/mxQueue/mxQueue.so mxQueue.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/TextTools/mxTextTools/mxTextTools.so mxTextTools.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/UID/mxUID/mxUID.so mxUID.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/URL/mxURL/mxURL.so mxURL.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/BeeBase/mxBeeBase/mxBeeBase.so mxBeeBase.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/DateTime/mxDateTime/mxDateTime.so mxDateTime.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/Stack/mxStack/mxStack.so mxStack.so()(64bit) python-mx.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/mx/Tools/mxTools/mxTools.so mxTools.so()(64bit) python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/Proxy/mxProxy/mxProxy.so 0775L python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/BeeBase/showBeeDict.pyo python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/BeeBase/showBeeDict.pyc python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/TextTools/mxTextTools/testkj.pyc python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/TextTools/mxTextTools/testkj.pyo python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/Queue/mxQueue/mxQueue.so 0775L python-mx.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/mx/BeeBase/mxBeeBase/testernesto.py /usr/local/bin/python python-mx.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/mx/BeeBase/mxBeeBase/testernesto.py 0644L /usr/local/bin/python python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/TextTools/mxTextTools/mxTextTools.so 0775L python-mx.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/mx/Misc/Daemon.py 0644L /usr/bin/env python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/Stack/stackbench.pyc python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/Stack/stackbench.pyo python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/DateTime/mxDateTime/test.pyc python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/DateTime/mxDateTime/test.pyo python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/UID/mxUID/mxUID.so 0775L python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/Queue/queuebench.pyc python-mx.x86_64: W: python-bytecode-without-source /usr/lib64/python2.7/site-packages/mx/Queue/queuebench.pyo python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/URL/mxURL/mxURL.so 0775L python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/BeeBase/mxBeeBase/mxBeeBase.so 0775L python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/DateTime/mxDateTime/mxDateTime.so 0775L python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/Stack/mxStack/mxStack.so 0775L python-mx.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/mx/Tools/mxTools/mxTools.so 0775L python-mx-devel.x86_64: W: self-obsoletion mx-devel obsoletes mx-devel python-mx-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 13 errors, 29 warnings. - The name of the spec should be python-mx.spec. - Please version the obsoletes and provides: Obsoletes: mx < 3.2.0-2 Provides: mx = %{version}-%{release} and analogously for devel. - The requires must be architecture specific, e.g., -devel must have Requires: %{name}%{?_isa} = %{version}-%{release} http://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package - Fix the self-obsoletion stuff. - What is the pybasever macro used for? - The BuildRoot tag (and its value!) is obsolete. If you're not targetting EPEL, you can remove the cleaning from %install, the %clean section altogether, the BuildRoot tag and the %defattr clauses, all of which are defaulted by current RPM. - Consider replacing %define 's with %global 's. http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - You need to use a filter for the libraries: # we don't want to provide private python extension libs %{?filter_setup: %filter_provides_in %{python_sitearch}/.*\.so$ %filter_setup } as in http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Arch-specific_extensions_to_scripting_languages - Installed .so libraries should have 755 permissions. - Patch1 is missing a description in the spec file. What does it do? - I suggest adding a tailing / in %files to %{python_sitearch}/mx to make it clear it is a directory (a trailing slash is also used in -devel). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review