Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707199 --- Comment #12 from Mark McLoughlin <markmc@xxxxxxxxxx> 2011-07-29 08:49:15 EDT --- Some of the things Matt listed that still need sorting: - correct the version to reflect this is a bzr snapshot - DB migration shouldn't be in %post Some other things that need sorting: - does the nova user/group need registering? I've forgotten the policy - there shouldn't be a warning about SELinux being enabled in %post - shouldn't be modifying sudoers in %post - the package requires openstack-glance and openstack-client, neither of which are packaged AFAICS - the cc-config and compute-config packages are used to package two different versions of nova.conf. I think the base nova package needs a nova.conf and further configuration should be left to the admin - the initscripts use start-stop-daemon, whereas we'd use the daemon function in Fedora. We should fix that rather than packaging start-stop-daemon. Also, perhaps we'd be better jumping straight to systemd rather than using sysvinit - nitpicky perhaps, but someone else could take over this spec and submit it, if we got confirmation from the mirantis and griddynamics that they are happy for their work to be contributed under the FPCA (e.g. they could license the spec under MIT) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review