Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: greylistd - Greylisting daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220891 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-01-10 07:57 EST ------- MUST - rpmlint checks return: on greylistd-0.8.3.2-7.at.src.rpm W: greylistd no-url-tag E: greylistd unknown-key GPG#66534c2b As explained in comment #2 the warning is due to lack of homepage for the project, second one can be safey ignored. However I suggest using ftp://ftp.debian.org/debian/pool/main/g/greylistd/ as URL. Second one can safely be ignored. on generated binary: W: greylistd no-url-tag E: greylistd non-standard-uid /var/run/greylistd/socket greylistd E: greylistd non-standard-gid /var/run/greylistd/socket greylistd E: greylistd non-standard-uid /var/run/greylistd greylistd E: greylistd non-standard-gid /var/run/greylistd greylistd E: greylistd non-standard-uid /var/lib/greylistd greylistd E: greylistd non-standard-gid /var/lib/greylistd greylistd E: greylistd non-standard-dir-perm /var/lib/greylistd 0750 E: greylistd non-standard-uid /var/lib/greylistd/states greylistd E: greylistd non-standard-gid /var/lib/greylistd/states greylistd E: greylistd non-readable /var/lib/greylistd/states 0640 E: greylistd non-standard-uid /var/lib/greylistd/triplets greylistd E: greylistd non-standard-gid /var/lib/greylistd/triplets greylistd E: greylistd non-readable /var/lib/greylistd/triplets 0640 All these can be ignored since the package creates its own user to run as and makes some files available just to said user - package meets naming guidelines - package meets packaging guidelines - license ( GPL ) is OK and matches source (based on examining the man pages) - spec file legible, in am. english - source matches upstream, sha1sum c634919b301f9d34c7609bf8fbf236362fc54295 greylistd_0.8.3.2.tar.gz - package compiles and builds on FC6 and devel (i386) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - duplicate file: %{_initdir}/greylistd - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no static, headers or libtool files SHOULD - compiles and builds in mock for FC6/i386; result is noarch (the whole lot consists of some python scripts) so no reason to not build on other archs - pre/post are sane - no sacrifice box to test the scripts on , I can only assume they work as intended :( This package is APPROVED but please do not forget to remove the duplicate entry for %{_initdir}/greylistd before importing. And you should also bug upstream to include the license in the tar file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review