Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705363 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-07-29 03:52:09 EDT --- > TODO: spacewalk-html subpackage contains MIT licensed code > (html/javascript/controls.js, > http://madrobby.github.com/scriptaculous/license/). Add proper value to License > tag for this subpackage. Actually the javascript code is in separate files. The MIT code does not combine with GPL code until it reaches client web browser, so the MIT code is not infected by GPL code in source nor binary RPM package. Thus I conclude adding `MIT' to package license tag is a must. Thus: FIX: Add MIT to license tag of spacewalk-html sub-package. And yet another problem. The Perl modules are installed into global Perl vendor directory, thus they are accessible by any other Perl programs. Also your Perl modules contain tests and other Perl infrastructure that is not utilized by your spec file. In other words the Perl modules seem to be bundled to spacewalk-web source tar ball and thus should be packaged as standalone RPM packages (with running tests) by standalone SPEC files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review