Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726486 Ian Weller <ian@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Ian Weller <ian@xxxxxxxxxxxxx> 2011-07-28 15:57:12 EDT --- [ OK ] specfiles match: fbeab392a2ab1727d33d983f6f4a5cc5 verne-backgrounds.spec fbeab392a2ab1727d33d983f6f4a5cc5 verne-backgrounds.spec.1 [ OK ] source files match upstream: 76e4d55069ff014a81c3ee4b919284f2 verne-backgrounds-15.91.0.tar.xz 76e4d55069ff014a81c3ee4b919284f2 verne-backgrounds-15.91.0.tar.xz.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ N/A ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3236394 [ OK ] package installs properly. [ N/A ] debuginfo package looks complete. [ OK ] rpmlint is silent. (only no-documentation and dangling-relative-symlink warnings, these are fine) [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ N/A ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ N/A ] scriptlets match those on ScriptletSnippets page. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ N/A ] no headers. [ N/A ] no pkgconfig files. [ N/A ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. ----------------------------------------------------------- This package (verne-backgrounds) is APPROVED by ianweller ----------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review