[Bug 711848] Review Request: kmetronome - KDE MIDI Metronome using ALSA Sequencer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711848

Martin Gieseking <martin.gieseking@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking@xxxxxx

--- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-28 03:46:35 EDT ---
Just some more comments:

- The package doesn't build in mock because of missing BR gettext.

- Remove folder drumstick/ in %prep to ensure that the bundled library is not
  linked.

- The .desktop file must be properly installed/validated as described here:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
  I'm not sure if there's an exception for KDE applications now.

- Drop %doc from the manpage. It's automatically tagged as doc file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]