Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226309 Alexander Kurtakov <akurtako@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@xxxxxxxxxx --- Comment #3 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2011-07-28 01:36:24 EDT --- I would do this one. Initial comments based on getting a smaller spec for the official review: * would you please drop gcj_support from the spec to remove a good number of lines :) * Requires(post|postun): jpackage-utils and %post/postun %update_maven_depmap are no longer needed on F15+ * empty "export CLASSPATH=" line can be removed * rm -rf ${RPM_BUILD_ROOT} in %install and %clean section can be removed in modern fedoras * %add_to_maven_depmap postgresql postgresql %{version} JPP postgresql-jdbc should become %add_maven_depmap JPP-postgresql-jdbc.pom %{name}.jar - it's quite more simple and detects groupId:artifactId automatically * %defattr(-,root,root) is no longer needed * there is no need in installing %{_javadir}/%{name}-%{version}.jar as per java guidelines %{_javadir}/%{name}.jar should be the default and versioned one is not needed * ant jar publicapi should be called and javadoc subpackage should be installed * BuildRoot definition can be safely removed Once these are done I'll do the official review. Or if you want I can do the changes and commit them push a new build - they shouldn't take more than 10 mins. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review