Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725909 Matej Cepl <mcepl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Matej Cepl <mcepl@xxxxxxxxxx> 2011-07-27 20:01:38 EDT --- (In reply to comment #2) > Regarding a) + b): I fired some test builds and I will remove the additional > CFLAGS in the Zarafa package for the next build and thus in php53-mapi, too. > Is it okay, if I apply this change after import into git? It's the removal of > the "export CFLAGS=..." line in the end. I would treat this as minor change. Certainly. After discussing it with some people Red Hat I have not even expected we would be able to have strict aliasing on, so I would never reject this review because of that. If you are able to make it working, it would just an additional awesomeness. > Yes, there are locales in po subdirectory, but they're built to *.mo with the > build of the main zarafa package and packaged into zarafa-client subpackage. > The php53-mapi package depends on zarafa-client as follows: > > 1. php53-mapi requires libmapi.so.0()(64bit) > 2. libmapi provides libmapi.so.0()(64bit) > 3. libmapi requires zarafa-client (because it dlopen()s libzarafaclient.so) > 4. zarafa-client provides *.mo (and thus the compiled *.po files) > 5. The gettext domain that is used everywhere is zarafa, not php53-mapi The relevant point is that php53-mapi apparently doesn't own any .mo files itself. If gettext is used by some library than catalogue management is business of that package not php53-mapi. > Was I able to clarify all your questions? To my deepest satisfaction. APPROVED Ask for git repo please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review