Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726080 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-27 14:11:55 EDT --- Hi Casper, first of all, please enter your full real name in the bugzilla preferences and also use it in the spec's %changelog. Here are a couple of quick comments on your package: - Use the main GNU URL in Source0: ftp://ftp.gnu.org/gnu/xnee/xnee-%{version}.tar.gz - Is this release really a pre-release (rc1)? I can't find any information on this. - According to the source file headers, the license of xnee is GPLv3+. - The package currently doesn't build because of missing BuildRequires: libXtst-devel gtk+-devel gtk2-devel - As the package provides a GUI application, you must add and install a .desktop file as described here: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - The tarball contains the sources of libxnee. I suggest to build the shared library and package it as well. It could be useful for other packages and/or developers. - If you plan to build the package for EPEL < 6 as well, add rm -rf %{buildroot} at the beginning of the %install section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review