[Bug 716475] Review Request: game-music-emu - A collection of video game music file emulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716475

--- Comment #2 from Karel Volný <kvolny@xxxxxxxxxx> 2011-07-27 09:46:31 EDT ---
(In reply to comment #1)
> * > Summary: A collection of video game music file emulators
> 
> Since summaries starting with "A ..." still make a bad reading when displayed
> in package installers and Anaconda, I suggest using the summary from the
> project's web site:
> 
> Summary: Video game music file emulation/playback library

ah, I've missed that line - I've used what's on "Project Home" below

> * I agree with the comments on the rpmlint warnings. :)
> 
> * The demo player and WAV writer source code use a different license, an "MIT"
> variant. Please consider that when importing the package.

good catch ... I'm not much into the legal stuff, I just took what's written on
the project page

I've e-mailed the author about this, for now I'd just silently ignore this
(LGPL is more restrictive, so anyone obeying LGPL also obeys the real license
of the affected files)

> * gme_player (x86_64) works with a couple of test files I have here.
> 
> APPROVED

cool, thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]