[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711547

--- Comment #18 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-07-27 08:59:14 EDT ---
(In reply to comment #17)
> in regards to your question 3. please read:
> https://bugzilla.redhat.com/show_bug.cgi?id=711547#c6
> 
> I am not sure what the compile issue is with the documentation, I asked the
> maintainer and they are now using OS X, but again, the information provided
> there is no different than what is on the web, so once I do get the docs
> compiling I can break out a sketch-docs sub package.

That's fine, I would handle this by leaving the % on the front of doc so it
doesn't look like a mistake (sure rpmlint will complain but we know why it's
there) and put a comment above it with a brief description on why it's
currently commented out.

Really, it's a best practice to put in comments any time you're doing something
non-standard so Proven Packagers, co-maintainers, or possible future owners of
the package will know why you did something.

Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]