Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725614 --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2011-07-26 13:42:13 EDT --- package name: ok spec file name: ok packaging guidelines: ok only comment here: %defattr() is no longer necessary, could be dropped license: ok license field: ok license file: we should probably drop the COPYING-DOCS and COPYING files which are leftovers from seahorse, and only keep the COPYTING-LIBCRYPTUI one which applies to this package. spec file language: ok spec file readability: ok upstream sources: ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok, just odd to use seahorse as the domain ldconfig: ok. would be slightly nicer to move the ldconfig call to -p for postun, but no biggie system libs: ok relocatable: ok directory ownership: should you take over ownership of %{_datadir}/seahorse and %{_datadir}/seahorse/ui here ? duplicate files: ok permissions: ok macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok utf8 filenames: ok summary: - drop extraneous license files, and ask upstream to clean that up too - ask upstream to clean up the seahorse leftovers (gettext domain, directories) - clean up directory ownership of /usr/share/seahorse/ui Other than that, looks good -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review