Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725587 --- Comment #3 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-07-26 10:35:26 EDT --- [clalance@localhost SPECS]$ rpmlint ../RPMS/noarch/condor-cloud-0.1-2.fc14.noarch.rpm condor-cloud.noarch: E: script-without-shebang /usr/libexec/condor/cloud_functions condor-cloud.noarch: E: non-standard-dir-perm /var/lib/condor-cloud/local_cache 0711L condor-cloud.noarch: W: non-conffile-in-etc /etc/condor/config.d/50condor_cloud.config condor-cloud.noarch: W: empty-%post condor-cloud.noarch: W: empty-%postun 1 packages and 0 specfiles checked; 2 errors, 3 warnings. [clalance@localhost SPECS]$ rpmlint ../RPMS/noarch/condor-cloud-node-0.1-2.fc14.noarch.rpm condor-cloud-node.noarch: E: script-without-shebang /usr/libexec/condor/cloud_functions condor-cloud-node.noarch: E: non-standard-dir-perm /var/lib/condor-cloud/local_cache 0711L condor-cloud-node.noarch: W: non-conffile-in-etc /etc/condor/config.d/50condor_cloud_node.config 1 packages and 0 specfiles checked; 2 errors, 1 warnings. So, let's see. For the script without a shebang, we can ignore the error, since that is allowed with what we are doing here. We should change the non-standard permissions to a standard 755, or 700 if it is sensitive. We should also mark the config file /etc/condor/config.d/50condor_cloud_node.config as %config. Finally, both condor-cloud and condor-cloud-node own the same files. I think the intention here is that they live on separate machines; if that is the case, then they should Conflicts with each other, since they own the same files. I'll do another post with other parts of the review, but this is enough to get started. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review