Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725570 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review+ --- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-07-26 10:25:53 EDT --- There are some minor items which are not necessary unless you're building for EPEL, specifically: * BuildRoot * rm -rf $RPM_BUILD_ROOT at the beginning of %install * %clean section that simply does rm -rf $RPM_BUILD_ROOT * %defattr(-,root,root,-) lines in %files sections All of these are the implicit defaults now (except in EL-4 and EL-5). Consider removing them before import if you do not plan on supporting those targets. == Review == Good: - rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream bfc888fc457b3f1b5a6442393eb157a22080059a2f90dff0564a62f1fdd43868 - package compiles on devel (koji) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - docs subpackage okay - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review