Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksshaskpass - A KDE version of ssh-askpass with KWallet support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221957 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-01-09 16:21 EST ------- Otherwise, package is pretty simple (and easy to review). (: * SOURCE matches upstream: md5sum 3d0addbecfcb31aedb59f36f7a34b349 ksshaskpass-0.3.tar.gz The more I think about it (comment #3), the more I think /etc/kde/env should be used for the startup script. We definitely don't want SSH_ASKPASS defined for console/text sessions, so * MUSTFIX: put ksshaskpass.sh in /etc/kde/env * MUSTFIX: add ssh-add to ksshaskpass.sh per README (unless you had some good reason to omit that) fixup those items, and I think we have a winner. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review