Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725552 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-07-26 03:26:38 EDT --- Rafael: please set the status to ASSIGNED when you take on the bug. A few notes: - Don't repeat the name in the summary. It should be simply "A KISS parser to *nix config files" ^ note added r - BuildArchitectures is practically always written short as BuildArch. - License tag is incorrect, it should be LGPLv2+. - You are missing BR: python-devel, which is required for python packages. - The statement %if 0%{?fedora} BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif is silly, since it is missing version conditions. The first clause will always evaluate to true, unless you are going to target EPEL. However, in this case as well you can just BR: python-setuptools-devel and it will work at least on EPEL-5 and EPEL-6, where python-setuptools provides python-setuptools-devel. - You are mixing python and %{_python}, please choose a style and stick with it. - Missing COPYING in %doc. - Please don't use wildcards where they are not absolutely necessary, since their freeminded use makes it hard to see what actually gets owned by the package and can bite you if you're not careful (in this case, you might not see when egg files are not generated). Please change %{python_sitelib}/* to %{python_sitelib}/confparse.py* %{python_sitelib}/confparse-%{version}.py*.egg-info -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review