Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 --- Comment #13 from Damian L Brasher <fedora@xxxxxxxxxxxxxxxxx> 2011-07-25 09:47:47 EDT --- Hello Martin packaged tarball now matches upstream: $ md5sum diaser-1.1.0.tar.gz* fa29fdf1b78d55127a4070f3f6497943 diaser-1.1.0.tar.gz fa29fdf1b78d55127a4070f3f6497943 diaser-1.1.0.tar.gz.1 - diaser is a plain sysadmin tool and files located in these directories (diaser is a script/binary): $ rpm -ql diaser /usr/sbin/diaser /usr/share/doc/diaser-1.1.0 /usr/share/doc/diaser-1.1.0/COPYING /usr/share/doc/diaser-1.1.0/CREDITS /usr/share/doc/diaser-1.1.0/README /usr/share/doc/diaser-1.1.0/WARNING /usr/share/doc/diaser-1.1.0/diaser.conf.sample /usr/share/doc/diaser-1.1.0/manual.html /usr/share/doc/diaser-1.1.0/manual.txt /usr/share/man/man1/diaser.1.gz - the diaser config file (diaser.conf) has been renamed to diaser.conf.sample, this change is reflected upstream. - the macro %{name} is used consistently within %install and %files instead of diaser. - %changelog now only lists downstream package/spec changes. - the revision number has been added to each change log entry as specified. $ rpmlint SRPMS/diaser-1.1.0-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/diaser-1.1.0-1.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint SPECS/diaser.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [makerpm@fedora15 rpmbuild]$ I do need a sponsor and your offer will be appreciated:) In addition to previous informal reviews, I will let you know which packages I have reviewed - I am making a start now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review