Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libofx - A library for supporting Open Financial Exchange (OFX) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221944 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-01-09 15:05 EST ------- MUST - rpmlint is silent on bioth src and binary packages - package meets naming guidelines - package meets packaging guidelines - license (GPL ) is OK, text in %doc, matches source - spec file legible, in am. english - source is latest version (0.8.3), matches upstream; sha1sum 0fa22f0535c1f50d4b9056f6f86d1429f1c8485f libofx-0.8.3.tar.gz - package builds on devel (x86 and i386) - missing BR: libtool - no unnecessary BR - no locales - not relocatable - owns all directories and files that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - docs and examples are included in the -devel package - nothing in %doc affects runtime - no need for .desktop file - post/postun ldconfig ok - no scriptlets but ldconfig - devel package ok - no .la files - devel correctly requires base package and also pkgconfig (due to presence of .pc) SHOULD Items: - no translations - builds/installs on devel (i386 and x86_64; no ppc to test on) - none of the bundled binaries segfaults on i386 Add the missing BR (libtool) and the package is APPROVED. Suggestion: since you do not build all the included binaries (ofxconnect) and the main purpose is just the library anyway, how about moving the bundled binaries (ofx2qif,ofxdump) to a separate ofx-tools or smtg similar ? They do not seem of much use -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review