Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725292 Nathan Owe <ndowens04@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ndowens04@xxxxxxxxx --- Comment #1 from Nathan Owe <ndowens04@xxxxxxxxx> 2011-07-24 22:23:51 EDT --- I am currently not a packager nor a sponsor but I will list a problem or problems: 1. Need to either use %{buildroot} or $RPM_BUILD_ROOT not both. 2. %defattr is no longer nessasary 3. License field needs to be GPLv2+ and not GPL 4. Missing Several build dependencies: a.libcurl-devel b.libxml2-devel c.openssl-devel 5. Remove Requires: Explicit Requires is not suggested. 6. passwd-s3fs is non-readable since the permissions on the file is set to 640. I would probably install it as 644 and set it as an example config file, so that the user can set it and set the permissions to how he or she wants it to be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review