Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725228 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-24 15:09:10 EDT --- Just a couple of quick comments: - adapt Source0 according to http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net - Drop BR: gcc-c++. It's present by default http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 - There's no need to prefix the packages with "lib". Just put the library into the base package and the devel files into %{name}-devel - Is it necessary to call qmake-qt4 %{name}.pro twice in %build? - Install the shared library files libqcodeedit.so* directly into %{_libdir} - The designer subpackage should require qt-devel for proper directory ownership. Maybe it would also make sense to move the plugin to the devel package instead of package it separately. - The devel package should also require qt-devel which provides directory %{_libdir}/qt4/mkspecs/features/ - The devel package must require the base package this way Requires: %{name}%{?_isa} = %{version}-%{release} The %{?_isa} part has been added to the guidelines lately: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package - You can drop Requires: pkgconfig. It's added automatically if necessary (still required for EPEL < 6, though). - Add GPL.txt to the base package. - The tarball contains a Doxyfile. Maybe it's a good idea to build the doxygen (html) documentation and add it to the devel package (or a separate doc package). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review