Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #5 from Till Maas <opensource@xxxxxxxxx> 2011-07-23 05:22:42 EDT --- (In reply to comment #4) > Some comments: > > *BuildRequires: > - You are using autoreconf in autogen.sh, so you must include it. Done. > *Remove the blank line at the end of the file. Done > The following are not oficially part of guideliness (but I think that are in > its spirit): > > *Summary > - The problem with hxtools summary is that says nothing specific to the > package! Would you install some package that you ever heard in the life with > such a description? :-) > > *Well let's read the description > - Oh, I see, now it's clear enough! No, not really, I am joking. You are > forcing to either read the code, go to the project site or read the man pages > > *I think you made two interesting programs that make *two specific tasks" Why > don't you make two different packages in the UNUX-style? :) I am not the author of the tools/package and I only need two of them to be able to update pam_mount in Fedora. There is no real similiarity between the tools except the upstream author, therefore no good summary or description can be given. Updated files: Spec URL: http://till.fedorapeople.org/review/hxtools.spec SRPM URL: http://till.fedorapeople.org/review/hxtools-20110721-1.tillf14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3224706 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review