Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725128 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-23 03:47:53 EDT --- Here are some initial comments: - The license seems to be GPLv2+ according to the copyright info in phat/phatknob.c. - Drop BR: gtk-doc, and add Requires: gtk-doc to the docs package. - I recommend to replace the explicit name "phat" with %{name} in the Requires fields. It ensures that the subpackages always require the base package even if the name changes for some reason. - As the devel package contains more than just the header files, I suggest to mention the other files as well. - Please be a bit more specific in %files: %{_bindir}/phat* - To simplify future updates, avoid mentioning the soversion and replace %{_libdir}/libphat.so.0* with %{_libdir}/libphat.so.* - Fedora usually doesn't ship static libraries except if necessary for some purpose. Thus, add --disable-static to %configure and drop the .a file from %files devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review