Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libundo - Undo/redo information managing library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221184 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-01-09 11:54 EST ------- (In reply to comment #2) > Well, I could reply with a quote: “we don't create evil, we only package it”. ... and it's task of a review not to let pass through all kind of junk ;) > I could add extern C guards if someone could tell me how to do so. You should find this in all C-books having been released since 1989: #ifdef __cplusplus extern "C" { #endif .... #ifdef __cplusplus } #endif > As for > installation dir, I think that putting a single header into its own subdir is a > bit of an overkill. The number of headers doesn't matter. One single header is as evil as is a dozen. /usr/include is in the compiler's default header search path, so any poorly designed package installing a header inside is likely to conflict with other headers. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review