Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724942 Veeti Paananen <veeti.paananen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veeti.paananen@xxxxxxxxxx --- Comment #4 from Veeti Paananen <veeti.paananen@xxxxxxxxxx> 2011-07-22 13:25:01 EDT --- Some additional comments: - The common format for the release tag is 1%{?dist} - The following build requirements are part of the default build environment, so you should drop them: gcc, libtool & automake - The devel package needs to use the following requirement to require the base package (http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package): Requires: %{name}%{?_isa} = %{version}-%{release} - You can avoid listing all the files explicitly by using wildcards. For example, in the base package's files section: %{_libdir}/libmodbus.so.* Something like this for manual pages: %{_mandir}/man3/*.3.* (Since the compression format may change from gzip, it's better to not to list "gz".) And you can just list the include directory: %{_includedir}/modbus/ > * Don't use %makeinstall macro. Use make install DESTDIR=$RPM_BUILD_ROOT instead Since you're already using %{buildroot} elsewhere, use make install DESTDIR=%{buildroot} since variable & macro styles may not be mixed. (http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review