Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #3 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2011-07-22 05:42:57 EDT --- (In reply to comment #2) > I have updated spec and source according to remarks. Files are updated on > remote site (same url) We normally update the %changelog to reflect the changes made to the spec file. > For Source, upstream archive is not named according expected format. I cannot > really change this, (quite a mess to maintain different source package for > different distributions). So I define, as proposed in Fedora policy, the file > name. URL to use and script to apply are defined in comments and Source1 Could you elaborate on this ? What is the format ? You don't have to maintain source package for each distro, just one with the correct installer (ant/pom/setup.py/makefile/install.sh), then it is up to the packager. Also, looking at the sources quickly, you seem to embed apache-commons-cli instead of using the one on the system. This is not allowed (bundle library). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review