[Bug 721112] Review Request: vmtk - The Vascular Modeling Toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721112

--- Comment #12 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-07-21 15:43:16 EDT ---
(In reply to comment #10)
> (In reply to comment #7)
> > Ok, after installing the other BuildRequires I got my cmake patch working!
> > 
> > Next issue: 
> > Are you on a 32bit or 64bit system? I noticed that "make install" doesn't put
> > the libraries in /usr/lib64 on x86_64 systems. I added a %ifarch conditional to
> > move /usr/lib to /usr/lib64 on x86_64 and ppc64 systems.
> 
> I run mock builds for a 32 bit system. I haven't tried on an x86_64 yet. 

Ok, my updated spec/SRPM file[1] fixes that.


> I just looked at CMakeLists.txt. I think setting "VMTK_MODULE_INSTALL_LIB_DIR"
> would fix this.
> -DVMTK_MODULE_INSTALL_LIB_DIR:STRING=$RPM_BUILD_ROOT/%{_libdir}/ or something
> on these lines. Again, I'll try it out and confirm.

Didn't work for me. It appears to just control the /usr or /usr/local part of
the path, I set it to /lib64 (since it adds /usr seperately) and it ended up
putting the files in /usr/lib64/lib/vmtk/vmtk... 



> > Second issue:
> > I noticed it put all the python files in /usr/lib/vmtk/vmtk. I think all of
> > these should go into %{python_sitelib}/vmtk, right?
> 
> Yes. Should. Again, setting VMTK_MODULE_INSTALL_LIB_DIR just might do the
> trick.

Probably will not work but worth a try... The problem is all the .py files need
to go in %{python_sitelib} which is /usr/lib/pythonX.X/site-packages/ while the
.so python libraries need to go in %{python_sitearch} which can be the same as
%{python_sitelib} for 32bit systems but is /usr/lib64... for 64 bit systems.
This is easier just to manage manually.

The only side effect I've found so far is that one (and only one) of the python
.so libraries actually has a SONAME and the .so symlink is getting pulled into
the regular package instead of the -devel package. Should be easy to fix
though, there are other bigger problems...

One of the "big" problems is actually with vtk, not vmtk. It provides a
necessary library, libVPIC.so, but only in the -devel package, not in the main
package. Because of that I had to add a Requires for vtk-devel which pulls in a
bunch of dependencies we don't need just to get the one file we do need. I
added a BZ reference in the comment so we can watch to see when it get's fixed.

The other problem seems to be that some of the libraries from vmtk can't find
other libraries it provides. In other words, it's finding libraries in
/usr/lib{,64} but not the ones in /usr/lib{,64}/vmtk... Not sure why that is
happening.

That's enough for now I think!

[1] http://hobbes1069.fedorapeople.org/vmtk/vmtk-0.9.0-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]