[Bug 721112] Review Request: vmtk - The Vascular Modeling Toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721112

--- Comment #10 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-07-21 14:19:33 EDT ---
(In reply to comment #7)
> Ok, after installing the other BuildRequires I got my cmake patch working!
> 
> Next issue: 
> Are you on a 32bit or 64bit system? I noticed that "make install" doesn't put
> the libraries in /usr/lib64 on x86_64 systems. I added a %ifarch conditional to
> move /usr/lib to /usr/lib64 on x86_64 and ppc64 systems.

I run mock builds for a 32 bit system. I haven't tried on an x86_64 yet. 

I just looked at CMakeLists.txt. I think setting "VMTK_MODULE_INSTALL_LIB_DIR"
would fix this.
-DVMTK_MODULE_INSTALL_LIB_DIR:STRING=$RPM_BUILD_ROOT/%{_libdir}/ or something
on these lines. Again, I'll try it out and confirm.

> 
> Second issue:
> I noticed it put all the python files in /usr/lib/vmtk/vmtk. I think all of
> these should go into %{python_sitelib}/vmtk, right?

Yes. Should. Again, setting VMTK_MODULE_INSTALL_LIB_DIR just might do the
trick.

I'll try all of this out and post :)

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]