Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722249 --- Comment #6 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2011-07-21 05:53:46 EDT --- Hi Ankur, I've a few things that need addressing: * Missing %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) http://fedoraproject.org/wiki/Packaging:Python#Macros * Description is longer than 80 characters, and you can probably remove the link as it is not relevant in this section. * Your BuildRequires section should be: BuildRequires: python2-devel BuildRequires: python-setuptools-devel * %defattr required in %files section. * Missing %doc where you need to include LICENSE, README.rst etc. I noticed that SOURCES.txt and the MANIFEST list docs/* and tests/* which are not included in your package - I'm not sure if they were meant to be. Also, the source included in the SRPM does not match the source URL listed in the spec file. It looks to me to be a later version obtained from the git repository? If so, you need to update the the version and add comments indicating how you obtained it. cheers, Brendan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review