Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-twisted - Twisted is an event-based framework for internet applications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221310 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2007-01-09 02:10 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - Spec in American English OK - Spec is legible. OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag Issues: 1. The README.fedora is a bit on the terse side. You might have it list out the other packages that this one pulls in or at least repeat the summary, but thats not a big deal or a blocker. I think the obsoletes and provides are correct here. I tried to upgrade a fc6 python-twisted with this version and it correctly pulled in the packages and installed. I did notice one install on removal of any of the python-twisted-* packages that did the /usr/libexec/twisted-dropin-cache call in postun. If you remove them and python-twisted-core, rpm removes python-twisted-core first, resulting in a failed scriptlet on the other package, ie: rpm -e python-twisted-core python-twisted-words error: %postun(python-twisted-words-0.4.0-3.fc6.i386) scriptlet failed, exit status 255 I think those packages need a Requires(postun): python-twisted-core I see no issues with this meta package, so I would be happy to APPROVE it. Don't forget to close this NEXTRELEASE once it's been imported and built. Also, once it's been pushed to fc6, you should be able to rebuild flumotion there and hopefully fix the broken fc5->fc6 upgrade path in it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review