Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683974 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #7 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-20 15:04:21 EDT --- Christoph, your package looks almost fine. However, there are a few issues that need some attention: - As the updater might pull in new files not yet present in the package from a third-party website, this could be a blocker. I asked on IRC how to handle this. It was recommended to ask FESCo [1] whether xvst can be added to Fedora. - The archive bundles and uses the third-party library qtsingleapplication (in folder src/qtsingleapplication). This is not allowed in Fedora: http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries You must remove the bundled sources in %prep and patch the build system of xvst so that the Fedora packages qtsingleapplication and qtsingleapplication-devel are used instead. - There are a couple of binary files in the zip file, e.g. tools/MigrationTool/Windows/1_8_2a-to-2_0a/rc/brcc32.exe. Please remove them in %prep. You should also ask upstream to drop them from the package. http://fedoraproject.org/wiki/PackagingGuidelines#No_inclusion_of_pre-built_binaries_or_libraries [1] http://fedoraproject.org/wiki/Fedora_Engineering_Steering_Committee -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review