Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libofx - A library for supporting Open Financial Exchange (OFX) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221944 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-01-09 00:17 EST ------- Some remarks: - Consider disabling building the static libs (%configure --disable-static) - Consider using "make DESTDIR=$RPM_BUILD_ROOT install" instead of %makeinstall - Could you explain the "Requires: openjade". AFAIS, this package only needs a certain version of libopensp and doesn't actually apply/require openjade. - Consider using a standard FE BuildRoot and using %{?dist}. I am not going to formally reviewing the package because of the %buildroot being used, sorry. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review