Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723472 Michal Fojtik <mfojtik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2011-07-20 06:23:37 EDT --- [ OK ] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname [ OK ] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version [ OK ] Package has proper license (ASL 2.0) [ OK ] The package must have a Requires and a BuildRequires on rubygems [ OK? ] The %prep and %build sections of the specfile should be empty. %build section is missing, but I though it's OK, since it's not required. [ OK ] The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [ OK ] The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [ OK] Architecture-specific content must not be installed into %{gemdir} There is no architecture specific content. [ OK] If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch. Marked properly. [ OK ] If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install This gem include only SSL certificate, which is not architecture specific. All clear to go so APPROVED. Nice work Marek! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review