Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721112 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hobbes1069@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-07-19 12:01:54 EDT --- I'll take this one for you. Some quick observations. 1. The %description is WAY TO LONG. 2. I think the -devel package requires should include %{?_isa} since this isn't a noarch pacakge: Requires: %{name}%{?_isa} = %{version}-%{release} 3. Could use more comments especially in %prep. I assume you're mainly removing bundled libraries there. Don't worry about posting a new release just yet until I can do a more in-depth spec review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review