Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722966 Veeti Paananen <veeti.paananen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veeti.paananen@xxxxxxxxxx --- Comment #1 from Veeti Paananen <veeti.paananen@xxxxxxxxxx> 2011-07-18 13:45:26 EDT --- Just commenting: - The build fails in mock for F15 x86_64. - Is the explicit mysql Require necessary? I couldn't actually test the package (see above) but a mock build for F14 shows that the automatic requirements do include libmysqlclient. If it is, you should add a comment to explain it (http://fedoraproject.org/wiki/Packaging:Guidelines#Requires). - CMakeLists.txt shouldn't be included in the documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review