Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 Mark McLoughlin <markmc@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markmc@xxxxxxxxxx AssignedTo|clalance@xxxxxxxxxx |markmc@xxxxxxxxxx Flag| |fedora-review? --- Comment #4 from Mark McLoughlin <markmc@xxxxxxxxxx> 2011-07-18 12:46:29 EDT --- The main issue I see is that you're packaging a snapshot of upstream's 0.0.1, but the package doesn't include the git commit ID in the release number rpmlint output: $> rpmlint rubygem-aeolus-image.spec rubygem-aeolus-image.spec:36: W: unversioned-explicit-obsoletes rubygem-aeolus-cli rubygem-aeolus-image.spec:37: W: unversioned-explicit-provides rubygem(aeolus-cli) 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $> $ rpmlint rubygem-aeolus-image-0.0.1-2.fc15.src.rpm rubygem-aeolus-image.src: W: spelling-error Summary(en_US) Commandline -> Command line, Command-line, Commanding rubygem-aeolus-image.src:36: W: unversioned-explicit-obsoletes rubygem-aeolus-cli rubygem-aeolus-image.src:37: W: unversioned-explicit-provides rubygem(aeolus-cli) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $> $ rpmlint rubygem-aeolus-image-0.0.1-2.fc14.noarch.rpm rubygem-aeolus-image.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/aeolus-image-0.0.1/ri/Aeolus/Image/PushCommand/combo_implemented%3f-i.yaml %3f rubygem-aeolus-image.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/aeolus-image-0.0.1/ri/Aeolus/Image/BuildCommand/combo_implemented%3f-i.yaml %3f rubygem-aeolus-image.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/aeolus-image-0.0.1/bin/aeolus-image 0775L rubygem-aeolus-image.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/aeolus-image-0.0.1/ri/Aeolus/Image/BaseCommand/is_file%3f-i.yaml %3f rubygem-aeolus-image.noarch: W: non-standard-dir-in-usr man 1 packages and 0 specfiles checked; 1 errors, 4 warnings. Review comments: - I really don't think we should worry about the aeolus-cli renaming. The cli pkg wasn't part of any upstream release or in Fedora, so I'd just ignore its existence If you still want to obsolete it, the obsoletes and provides should be versioned according to: http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages i.e. Provides: rubygem(aeolus-cli) = %{version}-%{release} Obsoletes: rubygem(aeolus-cli) < 0.0.1 - "Command-line" in Summary instead of "Commandline" - You want %{mandir}/* not %{mandir} - the pkg shouldn't own /usr/man/man1 - Also, it's /usr/share/man not /usr/man - in fact, use the %{_mandir} macro - I'm not sure what you're doing here: mkdir -p %{buildroot}/%{_bindir} mv %{buildroot}%{gemdir}/bin/* %{buildroot}/%{_bindir} find %{buildroot}%{geminstdir}/bin -type f | xargs chmod a+x rmdir %{buildroot}%{gemdir}/bin Are you chmod-ing the wrong file here? Perhaps you meant: mkdir -p %{buildroot}/%{_bindir} mv %{buildroot}%{gemdir}/bin/* %{buildroot}/%{_bindir} rmdir %{buildroot}%{gemdir}/bin rm -rf %{buildroot}%{geminstdir}/bin This fixes the non-standard-exuctable-perms error too btw -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review