Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720411 --- Comment #4 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-07-18 11:11:14 EDT --- + OK - NA ? Issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License ? License field in spec matches ^^^ [ankur@ankur OpenImageIO-oiio-8055b0f]$ find . -type f -execdir licensecheck '{}' \; | sed '/UNKNOWN/d' | sed -r 's/.\/.*://' | sort -d | uniq -c 26 BSD (2 clause) 188 BSD (3 clause) 20 GENERATED FILE 23 GPL (v2) 1 LGPL (v2 or later) (with incorrect FSF address) 24 MIT/X11 (BSD like) 212 *No copyright* GENERATED FILE So, there are quite a few Licenses in this package ;) To see what files use what, please remove the last three commands in the command chain above. ? License file included in package ^^^ Only the BSD license is included + Spec in American English + Spec is legible. + Sources match upstream md5sum: The SOURCE0 URL gives a 404. Probably because it generates a tar on the fly when you click download. [ankur@ankur SPECS]$ spectool -g OpenImageIO.spec Getting https://download.github.com/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz to ./OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:10 --:--:-- 0 curl: (22) The requested URL returned error: 404 The md5sums are okay though. [ankur@ankur SPECS]$ md5sum ~/dump/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz ../SOURCES/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz 29097c71383ba39a4d50bd3de1b6322d /home/ankur/dump/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz 29097c71383ba39a4d50bd3de1b6322d ../SOURCES/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. ^^^ %defattr, buildroot, clean section not required anymore + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. + Headers/static libs in -devel subpackage. + Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig + .so files in -devel subpackage. + -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. [ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/OpenImageIO.spec OpenImageIO-0.10.0-1.fc14.src.rpm OpenImageIO.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/OpenImageIO.so OpenImageIO.so OpenImageIO.src: W: invalid-url Source0: https://download.github.com/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz HTTP Error 404: Not Found ../SPECS/OpenImageIO.spec: W: invalid-url Source0: https://download.github.com/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz HTTP Error 404: Not Found OpenImageIO.src: W: invalid-url Source0: https://download.github.com/OpenImageIO-oiio-Release-0.10.0-12-g8055b0f.tar.gz HTTP Error 404: Not Found 5 packages and 1 specfiles checked; 0 errors, 4 warnings. [ankur@ankur SRPMS]$ Please do look at the warning. + final provides and requires are sane: == OpenImageIO-0.10.0-1.fc16.i686.rpm == Provides: OpenImageIO.so libOpenImageIO.so.0.10 OpenImageIO = 0.10.0-1.fc16 OpenImageIO(x86-32) = 0.10.0-1.fc16 Requires: /sbin/ldconfig /sbin/ldconfig libGL.so.1 libGLEW.so.1.6 libGLU.so.1 libHalf.so.6 libICE.so.6 libIex.so.6 libIlmImf.so.6 libIlmThread.so.6 libImath.so.6 libOpenImageIO.so.0.10 libQtCore.so.4 libQtGui.so.4 libQtOpenGL.so.4 libSM.so.6 libX11.so.6 libXext.so.6 libboost_filesystem-mt.so.1.46.1 libboost_program_options-mt.so.1.46.1 libboost_python-mt.so.1.46.1 libboost_regex-mt.so.1.46.1 libboost_system-mt.so.1.46.1 libboost_thread-mt.so.1.46.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.11) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libc.so.6(GLIBC_2.8) libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GLIBC_2.0) libjasper.so.1 libjpeg.so.62 libjpeg.so.62(LIBJPEG_6.2) libm.so.6 libm.so.6(GLIBC_2.0) libm.so.6(GLIBC_2.1) libpng12.so.0 libpng12.so.0(PNG12_0) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.2) libpthread.so.0(GLIBC_2.3.2) libpugixml.so.1.0 libpython2.7.so.1.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libstdc++.so.6(GLIBCXX_3.4.11) libstdc++.so.6(GLIBCXX_3.4.15) libstdc++.so.6(GLIBCXX_3.4.5) libstdc++.so.6(GLIBCXX_3.4.9) libtiff.so.3 libz.so.1 python(abi) = 2.7 rtld(GNU_HASH) == OpenImageIO-0.10.0-1.fc16.src.rpm == Provides: Requires: boost-devel glew-devel qt-devel OpenEXR-devel ilmbase-devel python2-devel txt2man libpng libtiff-devel zlib-devel jasper-devel pugixml-devel == OpenImageIO-debuginfo-0.10.0-1.fc16.i686.rpm == Provides: OpenImageIO-debuginfo = 0.10.0-1.fc16 OpenImageIO-debuginfo(x86-32) = 0.10.0-1.fc16 Requires: == OpenImageIO-devel-0.10.0-1.fc16.i686.rpm == Provides: OpenImageIO-devel = 0.10.0-1.fc16 OpenImageIO-devel(x86-32) = 0.10.0-1.fc16 Requires: OpenImageIO(x86-32) = 0.10.0-1.fc16 libOpenImageIO.so.0.10 SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. + Should have sane scriptlets. + Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Please check the licensing 2. Please check the rpmlint warning. The rest looks okay :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review