Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711899 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jon Ciesla <limb@xxxxxxxxxxxx> 2011-07-18 11:02:13 EDT --- Caveat: this is done using the version of rubygem-dnsruby currently being reviewed. - rpmlint checks return: opendnssec.x86_64: W: spelling-error %description -l en_US crypto -> crypt, crypts, crypt o The value of this tag appears to be misspelled. Please double-check. opendnssec.x86_64: W: spelling-error %description -l en_US softhsm -> Smithson The value of this tag appears to be misspelled. Please double-check. Minor. opendnssec.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Fix or document why this absolutely has to be this way. I see you're working on that. opendnssec.x86_64: E: non-readable /etc/opendnssec/conf.xml 0640L The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). opendnssec.x86_64: E: non-readable /etc/opendnssec/zonefetch.xml 0640L The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). opendnssec.x86_64: E: non-readable /etc/opendnssec/conf.xml.sample 0640L The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). opendnssec.x86_64: E: non-readable /etc/opendnssec/zonefetch.xml.sample 0640L The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). Ok. opendnssec.x86_64: W: no-manual-page-for-binary ods-kasp2html Each executable in standard binary directories should have a man page. Is one available? 2 packages and 0 specfiles checked; 4 errors, 4 warnings. - package meets naming guidelines - package meets packaging guidelines - license ( ) OK, text in %doc, matches source - spec file legible, in am. english FIX I'll check these after you update to rc3: ( - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR ) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Otherwise I think it's ok, so we just need rubygems-dnsruby, the lib/share issue, hopefully a man page, and I'll check the source/build bits once the new version is ready. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review