[Bug 711893] Review Request: rubygem-dnsruby - Ruby DNS(SEC) implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711893

Jon Ciesla <limb@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb@xxxxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |limb@xxxxxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Jon Ciesla <limb@xxxxxxxxxxxx> 2011-07-18 10:37:41 EDT ---
Good:

- rpmlint checks return:

Just the macro warnings.  Any update on this?

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ or Ruby ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Otherwise it looks good, running a Mock build to double-check BRs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]