Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715127 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #7 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-18 03:54:20 EDT --- Here are some further comments: - Please preserve the timestamps during the conversion of file encodings, e.g. with for f in doc/*.txt samples/*.abc doc/AUTHORS; do sed 's/\r//' $f >$f.new touch -r $f $f.new mv $f.new $f done - Don't mix macros and variables when using $RPM_OPT_FLAGS, $RPM_BUILD_ROOT, %{optflags}, or %{buildroot}. Choose one variant and stick with it. For example, replace $RPM_OPT_FLAGS with %{optflags} in the %build section. - Please be a bit more verbose in %files to avoid adding unwanted files and to help getting an overview of what's actually been packaged, e.g. %{_bindir}/abc* %{_bindir}/midi* %{_bindir}/mftext %{_bindir}/yaps %{_mandir}/man1/*.1* - The %description mentions four programs provided by the package, but there are seven: abc2abc, abc2midi, abcmatch, mftext, midi2abc, midicopy, yaps Maybe you can add short descriptions of the three missing ones. - Ask upstream to update the FSF address in gpl.txt and the source headers according to http://www.gnu.org/licenses/gpl-2.0.html $ rpmlint abcMIDI-*.rpm abcMIDI.x86_64: E: incorrect-fsf-address /usr/share/doc/abcMIDI-20110610/gpl.txt abcMIDI.x86_64: W: no-manual-page-for-binary abcmatch abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/parseabc.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/pslib.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/yapstree.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/position.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/drawtune.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/toabc.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/midi2abc.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/genmidi.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/store.c abcMIDI-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/abcmidi/queues.c 2 packages and 0 specfiles checked; 11 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review