Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705043 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-07-17 08:31:28 EDT --- - As has already been stated on fedora-devel, it is generally preferred to delete the files you don't want to ship at the end of %install, instead of excluding them in %files. - The usual convention is to apply any patches directly after %setup, unless the patches do not operate on pristine source files. Please convert the ChangeLog at the end of the %prep phase, after the patches have been applied. - It is also advisable to version the patches, e.g. Patch0: paco-2.0.9-fix-fsf-address.patch since often you might have to rebase these, and having a different content of the patch file in different branches (e.g. f14 vs f15) might be confusing. - You should ship %{_libdir}/*.so %{_libdir}/pkgconfig in a -devel package, since these can be used to compile against paco. Or do you have any specific reason why you don't want to ship these? PS. If you're on IRC, please join #fedora.fi on IRCNet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review