Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=704635 --- Comment #5 from Kalev Lember <kalevlember@xxxxxxxxx> 2011-07-16 14:23:09 EDT --- Fedora review mingw-gstreamer-0.10.35-1.fc15.src.rpm 2011-07-16 + OK ! needs attention rpmlint output: $ rpmlint mingw32-gstreamer \ mingw32-gstreamer-debuginfo-0.10.35-1.fc15.noarch.rpm \ mingw-gstreamer-0.10.35-1.fc15.src.rpm mingw32-gstreamer.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gstreamer-0.10.35/COPYING mingw32-gstreamer-debuginfo.noarch: E: debuginfo-without-sources mingw-gstreamer.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 59) 3 packages and 0 specfiles checked; 2 errors, 1 warnings. ! Please fix the mixed-use-of-spaces-and-tabs warning to make rpmlint happier. Other errors and warnings are harmless. + The package is named according to Fedora MinGW packaging guidelines ! The spec file name MUST match the base package name. The spec file name in the SRPM matches the package base name, but the one in dropbox is named 'mingw-gstreamer-0.10.35.spec'. Make sure that the spec file is named 'mingw-gstreamer.spec' when you import the package. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 4a0a00edad7a2c83de5211ca679dfaf9 gstreamer-0.10.35.tar.bz2 4a0a00edad7a2c83de5211ca679dfaf9 Download/gstreamer-0.10.35.tar.bz2 + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8 Issues: ! Would be nice to clean up the rpmlint warning about mixed-use-of-spaces-and-tabs ! Make sure you use the name the spec file 'mingw-gstreamer.spec' when importing the package. ! The following 3 lines are not needed on F15 and above and can be removed, unless you plan to build the package also for F14: %global _use_internal_dependency_generator 0 %global __find_requires %{_mingw32_findrequires} %global __find_provides %{_mingw32_findprovides} Very nice work for first package, keep up the good work! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review