Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522920 Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@xxxxxxxxxxxxx --- Comment #22 from Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> 2011-07-16 03:57:21 EDT --- Hi David, I will review this as requested, First to begin with can you: - Update to latest upstream - Change to using uniform macro's don't mix $RPM_BUILD_ROOT with %{buildroot} - Split the desktop integration into a sub package, some users just need the command line tnef for use with tools like mailscanner they do not need to be saddled with a whole desktop environment, since it does both gnome and kde you could have tnef-gnone and tnef-kde, or just tnef-desktop Will do the full review when this is done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review