Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708473 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx | |, | |fedora-mingw@lists.fedorapr | |oject.org Resolution|ERRATA | Keywords| |Reopened --- Comment #9 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2011-07-15 10:33:46 EDT --- I'm re-opening this review ticket as I don't agree with the 'review' which was done here. The .spec file which is attached here doesn't even build in mock! The .spec file which was imported in rawhide is in a bit better shape, but still not compliant with the general Fedora packaging guidelines and the MinGW-specific packaging guidelines: http://fedoraproject.org/wiki/Packaging:MinGW I'll do a proper review now based on what's now in rawhide (3.10.1-4.fc16). The Source0 and Source1 URL's are invalid: $ spectool -g mingw32-cxxtest.spec Getting http://cxxtest.tigris.org/files/documents/6421/43281/mingw32-cxxtest-3.10.1.tar.gz to ./mingw32-cxxtest-3.10.1.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Getting http://cxxtest.tigris.org/files/documents/6421/43284/mingw32-cxxtest-guide-3.10.1.pdf to ./mingw32-cxxtest-guide-3.10.1.pdf % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Please use working URLs or add a comment how the .tar.gz can be regenerated As your only targeting F-15 and rawhide, several things can be dropped from the .spec file like the BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' from the %install phase, the entire %clean section and the %defattr lines from both subpackages. The conditionals for fedora < 11 and rhel can also be dropped as they're unneeded when you only target F-15 and rawhide. Why are you bundling the python pieces with this package? We don't have python support in the MinGW toolchain in Fedora so the python pieces are kinda useless. The python code and the -doc subpackage are also bundled with the native Fedora cxxtest package so they can both the dropped from the mingw package. Is it correct that this package only provides some C++ header files? If that's the case then the two %global overrides can be dropped as they only apply to mingw binaries. Do note however that when this package starts to bundle binaries that several overrides need to be added (for dependency and debuginfo extraction). See the Fedora MinGW packaging guidelines for an example. If you aren't bundling any mingw binaries then you need add to a Requires: mingw32-filesystem manually. Why was this package imported as mingw32-cxxtest? The current Fedora MinGW guidelines strongly suggest to name new packages mingw-, so that in the future it would be easier to build mingw64- binary packages. Now that you've used mingw32- source package naming, you'll have to retire mingw32-cxxtest and re-review mingw-cxxtest once the mingw64 compiler is ready, probably in the F17 timeframe -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review