Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721063 --- Comment #2 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-07-15 09:15:12 EDT --- Spec: http://mo.morsi.org/files/aeolus/rubygem-factory_girl_rails.spec SRPM: http://mo.morsi.org/files/aeolus/rubygem-factory_girl_rails-1.0.1-2.fc15.src.rpm (In reply to comment #1) > Initial review: > > 1) There are a few lines in there that have trailing whitespace (like > Requires: ruby); not a huge problem, but nice to clean up. Done. > 2) The license is wrong; the spec says GPLv2+ or Ruby (which I know is the > default gem2rpm output), but the actual license of the gem is MIT. Done. > > [clalance@localhost SPECS]$ rpmlint > rubygem-factory_girl_rails-1.0.1-1.fc14.noarch.rpm > rubygem-factory_girl_rails.noarch: W: summary-not-capitalized C > factory_girl_rails provides integration between factory_girl and rails 3 > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > We can probably change that summary to "Provides integration between > factory_girl and rails 3" Done > [ FAIL ] MUST: The License field in the package spec file must match the > actual license Done > [ FAIL ] MUST: At the beginning of %install, each package MUST run rm -rf > %{buildroot} (or $RPM_BUILD_ROOT). rm -rf %{buildroot} in %install is no longer needed http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review