[Bug 683127] Review Request: tpm-quote-tools - TPM-based attestation using the TPM quote operation (tools)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683127

--- Comment #22 from William Lima <wlima@xxxxxxxxxxxxxx> 2011-07-14 12:50:49 EDT ---
SPECS/tpm-quote-tools.spec:44: W: macro-in-%changelog %makeinstall
SPECS/tpm-quote-tools.spec:47: W: macro-in-%changelog %changelog
SPECS/tpm-quote-tools.spec: W: invalid-url Source0: tpm-quote-tools-1.0.tar.gz

- Fix RPM macros in changelog (%%name instead of %name).
- Use Source0 instead of Source alias.
- Put link of gzip'ed tarball on Source0.
- I would change your Group tag to Applications/System.
- README says it requires tpm-tools. If so, add explicit require on tpm-tools.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]