[Bug 721179] Review Request: rubygem-extlib - Support library for DataMapper and Merb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721179

Ulrich Schwickerath <ulrich.schwickerath@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ulrich.schwickerath@xxxxxxx

--- Comment #1 from Ulrich Schwickerath <ulrich.schwickerath@xxxxxxx> 2011-07-14 11:41:09 EDT ---
Hi, Shawn,

you say you need it for building OpenNebula ? Which version ? Version 2.2.1
seems to run and compile fine without rubygem-extlib. 

Few comments:
1/ 
%global ruby_sitelib %(ruby -rrbconfig -e "puts Config::CONFIG['sitelibdir']")
should be conditional, eg something like this:
%{!?ruby_sitelib: %global ruby_sitearch %(ruby -rrbconfig -e "puts
Config::CONFIG['sitearchdir']")}

2/ in %setup, better do 
%setup -q -c -T 
cp %{SOURCE0} %{gemname}-%{version}.gem
and then in %build use %{gemname}-%{version}.gem instead of %{SOURCE0}
(Not an expert myself on this, I was asked myself to do it this way although
the twiki states to do it the way you do it. Twiki should be changed I think,
as well as many other packages)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]